gemmellr commented on a change in pull request #729:
URL: https://github.com/apache/activemq/pull/729#discussion_r811856704
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQSession.java
##########
@@ -1956,12 +1978,17 @@ protected void send(ActiveMQMessageProducer producer,
ActiveMQDestination destin
//Set the "JMS" header fields on the original message, see 1.1
spec section 3.4.11
message.setJMSDeliveryMode(deliveryMode);
long expiration = 0L;
- if (!producer.getDisableMessageTimestamp()) {
- long timeStamp = System.currentTimeMillis();
+ long timeStamp = System.currentTimeMillis();
+ if (timeToLive > 0) {
+ expiration = timeToLive + timeStamp;
+ }
+
+ // TODO: AMQ-8500 - update this when openwire supports
JMSDeliveryTime
+ message.setJMSDeliveryTime(timeStamp);
Review comment:
This still seems to be the 'original message' at this point, so note
this will throw if it was given a foreign providers JMS 1.1 impl message
object, which naturally doesnt implement the method since it doesnt exist for
them (remembering back to the previous discussion around why the message
set/get methods shouldnt throw UOE to avoid breaking other providers, and how a
2.0 provider can allow working with anothers existing 1.1 messages).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
