cshannon commented on pull request #778: URL: https://github.com/apache/activemq/pull/778#issuecomment-1048705020
Thanks for the PR, this looks like a good catch. A couple things: Pull requests should have a Jira associated with it describing the issue. https://issues.apache.org/jira/projects/AMQ . Also, ideally it would be good to include a unit test that can demonstrate the issue and show that it's fixed. In this case I'll create the Jira as I am going to re-work the fix slightly and I will a test real quick because we are about to do a new release but for the future you can keep that in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
