gemmellr commented on a change in pull request #784:
URL: https://github.com/apache/activemq/pull/784#discussion_r815944331
##########
File path: activemq-amqp/pom.xml
##########
@@ -77,10 +77,13 @@
<scope>test</scope>
</dependency>
<dependency>
- <!-- using it for Jetty's JNDI context to work /w Joram tests. -->
- <groupId>org.eclipse.jetty.aggregate</groupId>
- <artifactId>jetty-all</artifactId>
- <classifier>uber</classifier>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-server</artifactId>
+ <scope>test</scope>
+ </dependency>
Review comment:
The answer is its not strictly needed, as its a transitive dependency of
jettys websocket-server dep that already is used in the module, but is used and
so isnt really doing any harm adding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
