jbonofre commented on a change in pull request #789:
URL: https://github.com/apache/activemq/pull/789#discussion_r817798807
##########
File path:
activemq-unit-tests/src/test/java/org/apache/activemq/ProducerFlowControlTest.java
##########
@@ -261,7 +261,7 @@ public void testDisableWarning() throws Exception {
Appender appender = new DefaultTestAppender() {
Review comment:
Instead of the DefaultTestAppender, you can now use log4j
AbstractAppender with var as I did in other modules.
##########
File path:
activemq-unit-tests/src/test/java/org/apache/activemq/broker/region/QueuePurgeTest.java
##########
@@ -108,31 +108,30 @@ private void testPurgeLargeQueue(boolean
prioritizedMessages) throws Exception {
QueueViewMBean proxy = getProxyToQueueViewMBean();
LOG.info("purging..");
- org.apache.log4j.Logger log4jLogger =
org.apache.log4j.Logger.getLogger(org.apache.activemq.broker.jmx.QueueView.class);
+ org.apache.logging.log4j.core.Logger log4jLogger =
(org.apache.logging.log4j.core.Logger)LogManager.getLogger(org.apache.activemq.broker.jmx.QueueView.class);
+
final AtomicBoolean gotPurgeLogMessage = new AtomicBoolean(false);
Appender appender = new DefaultTestAppender() {
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]