jbertram opened a new pull request #3984: URL: https://github.com/apache/activemq-artemis/pull/3984
When using a temporary queue with a `temporary-queue-namespace` the `AddressSettings` lookup wasn't correct. This commit fixes that and refactors `QueueImpl` a bit so that it holds a copy of its `AddressSettings` rather than looking them up all the time. If any relevant `AddressSettings` changes the `HierarchicalRepositoryChangeListener` implementation will still refresh the `QueueImpl` appropriately. The `QueueControlImpl` was likewise changed to get the dead-letter address and expiry address directly from the `QueueImpl` rather than looking them up in the `AddressSettings` repository. I modified some code that came from ARTEMIS-734, but I ran the test that was associated with that Jira (i.e. `o.a.a.a.t.i.c.d.ExpireWhileLoadBalanceTest`) and it passed so I think that should be fine. There actually was no test included with the original commit. One was added later so it's hard to say for sure it exactly captures the original issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
