clebertsuconic commented on a change in pull request #3983:
URL: https://github.com/apache/activemq-artemis/pull/3983#discussion_r827355560



##########
File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
##########
@@ -213,6 +213,8 @@
 
    private static final String MAX_SIZE_BYTES_NODE_NAME = "max-size-bytes";
 
+   private static final String MAX_MESSAGES_NODE_NAME = "max-messages";

Review comment:
       @jbertram ok.. I like that actually.. I had thought about 
max-size-message and I thought it wouldn't be a good term because of English 
grammar...
   
   although global-max-messages it sounds fine as is I think? 
   
   global-max-size-messages wouldn't sound weird?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to