gemmellr commented on a change in pull request #3983:
URL: https://github.com/apache/activemq-artemis/pull/3983#discussion_r828153835
##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -894,6 +894,15 @@
</xsd:annotation>
</xsd:element>
+ <xsd:element name="global-max-messages" type="xsd:long" default="-1"
maxOccurs="1" minOccurs="0">
+ <xsd:annotation>
+ <xsd:documentation>
+ Number of messages before all addresses will enter into
their Full Policy configured.
+ It works in conjunction with global-max-message-size, being
watever value hits its maximum first.
Review comment:
There are no other mentions of global-max-message-size in the
codebase....global-max-size?
##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -3934,6 +3943,14 @@
</xsd:annotation>
</xsd:element>
+ <xsd:element name="max-size-messages" type="xsd:long" default="-1"
maxOccurs="1" minOccurs="0">
Review comment:
What about _max-size-message-count_? Would be consistent with the queues
use of MessageCount as its depth metric, and less likely to be confused in
discussion with bits around 'size of message' as opposed to 'number of
messages'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
