clebertsuconic commented on PR #3999: URL: https://github.com/apache/activemq-artemis/pull/3999#issuecomment-1090666094
@waldi5001 ``` merge commits are confusing.. I will avoid that. should we split some commits in a new PR? Wouldn't that be cleaner? ``` I would just for now: ``` git remote add upstream https://github.com/apache/activemq-artemis.git git pull --rebase upstream main git push origin -f ``` Right before commit, I would squash all the commits into a single commit... it's ok to keep separate commits while reviewing.. but this to me is a single unit of work... if you want to separate commits to make it more manageable is fine.. but on this PR you have for instance a commit just to fix check style.. that should be squashed. last time I checked all these commits could / should be squashed into a single commit and push -f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
