ehsavoie commented on code in PR #4009:
URL: https://github.com/apache/activemq-artemis/pull/4009#discussion_r845163811
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java:
##########
@@ -425,10 +425,10 @@
format = Message.Format.MESSAGE_FORMAT)
void broadcastTimeout(int retry, int maxretry);
- @LogMessage(level = Logger.Level.WARN)
- @Message(id = 212078, value = "Connection factory parameter ignored {0}",
- format = Message.Format.MESSAGE_FORMAT)
- void connectionFactoryParameterIgnored(String parameterName);
Review Comment:
Is it ok to remove the id 212078 or should I keep it in the debug trace ?
There is a test looking for it.
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/SimpleJNDIClientTest.java:
##########
@@ -111,22 +115,26 @@ public void testEmptyConnectionFactoryString() throws
NamingException, JMSExcept
//IIB v10 assumes this property is mandatory and sets it to an empty
string when not specified
props.put("java.naming.provider.url", "");
- new InitialContext(props);//Must not throw an exception
-
+ Context ctx = new InitialContext(props);//Must not throw an exception
+ ctx.close();
}
@Test
public void testConnectionFactoryStringWithInvalidParameter() throws
Exception {
+ Level initialLevel =
LogManager.getLogManager().getLogger("org.apache.activemq.artemis.core.client").getLevel();
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
