waldi5001 commented on code in PR #3999: URL: https://github.com/apache/activemq-artemis/pull/3999#discussion_r846432589
########## examples/features/sub-modules/artemis-jakarta-ra-rar/src/main/resources/ra.xml: ########## @@ -2,314 +2,309 @@ <!-- $Id: ra.xml 76819 2008-08-08 11:04:20Z jesper.pedersen $ --> -<connector xmlns="http://java.sun.com/xml/ns/j2ee"; - xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee - http://java.sun.com/xml/ns/j2ee/connector_1_5.xsd"; - version="1.5"> +<connector version="2.0" Review Comment: I want to prove you completely right, but if you are looking the diff with "ignore whitespace" you can see it well. In my comment of the commit I describes the changes: * update xml schemas * fix ConnectionParameters * remove TransactionManagerLocatorMethod and "The producer max rate" * remove The max connections nevertheless: With my next commit I reformat the file, and I hope the diff will become more readable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
