gemmellr commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r892261918
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java:
##########
@@ -1444,20 +1276,39 @@ public List<MessageReference>
getRelatedMessageReferences() {
private class CursorIterator implements PageIterator {
- private PagePositionAndFileOffset position = null;
+ // The cursorLogger is declared as static on the class, just to avoid a
getLogger() call every time
+ private final Logger logger = cursorLogger;
Review Comment:
Would the earlier part of the suggestion, of just using the existing static
variable you already declared at the top, still work? (rather than reassigning
it to the inner-class variable instance, which doesnt seem to achieve much)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
