gemmellr commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r896892036
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java:
##########
@@ -1172,15 +1044,9 @@ public final class PageCursorInfo implements
ConsumedPage {
private final long pageId;
- // Confirmed ACKs on this page
- private Set<PagePosition> acks = Collections.synchronizedSet(new
LinkedHashSet<PagePosition>());
-
- private WeakReference<PageCache> cache;
+ private IntObjectHashMap<PagePosition> acks = new IntObjectHashMap<>();
- private Set<PagePosition> removedReferences = new ConcurrentHashSet<>();
-
- // The page was live at the time of the creation
- private final boolean wasLive;
+ private IntObjectHashMap removedReferences = new IntObjectHashMap<>();
Review Comment:
Thats fine if thats its type, better than superfluous warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
