clebertsuconic commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r896897200
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java:
##########
@@ -673,15 +738,24 @@ public Page removePage(int pageId) {
return null;
}
- Page page = createPage(pageId);
+ Page page = usePage(pageId);
- if (page.getFile().exists()) {
+ if (page != null && page.getFile().exists()) {
+ page.usageDown();
Review Comment:
numberOfPages is orthogonal to usedPages here. it's just keeping the older
logic here as I did not change anything related to remove pages.
it could happen a cursor be passing through this and keeping the cache a bit
longer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
