brudo opened a new pull request, #23: URL: https://github.com/apache/activemq-nms-openwire/pull/23
I changed the default SslContext from "Tls" to "Default", which I believe will defer to the OS. I believe this is the correct behavior for a library. Note that I did not test the above change yet, so initially I am creating this as a draft pull request. _Under .NET Framework, depending on the OS version and how it was initially configured, it may be necessary to add/change the registry setting SchUseStrongCrypto to 1 for it to use secure protocols. I don't know if there is an equivalent setting required for .NET core 3.1 or .NET 6._ Other changes to remove most warnings when rebuilding all: - updated various tests where there was a warning about async without await, to await Task.CompletedTask. - removed a few variables that were not referenced (an Exception, and a timeout) to prevent a compile time warning This leaves only one warning, for use of the deprecated iconUrl as opposed to icon, in the nuspec. There were instructions for how to address that, but I left it alone, as I was not sure if it needed to stay that way for backward compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
