cshannon commented on PR #850:
URL: https://github.com/apache/activemq/pull/850#issuecomment-1170156331

   > @cshannon sounds good, I will be sure to use draft PR's in the future.
   > 
   > FWIW- in this instance, I was doing my last once over when I noticed the 
mbean had a 'resetStatistics' method and I didn't want to push in an incomplete 
feature.
   
   Maybe in this last commit but you've been pushed several commits since 
asking for a review and in general your usual workflow has been to submit a PR 
when it's not ready and add people for review and we all end up just getting a 
bunch of emails every time you force push a commit. The end result is I just 
treat it like spam and ignore it as I assume you are not done.
   
   With the draft PR at least we know it's a preview so we can take a look and 
check it out early to make comments if we want and then know you are finished 
if you mark it as a normal PR and not draft.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to