clebertsuconic commented on code in PR #4163:
URL: https://github.com/apache/activemq-artemis/pull/4163#discussion_r935603987
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SelectorTranslator.java:
##########
@@ -54,6 +56,17 @@ public static String convertToActiveMQFilterString(final
String selectorString)
}
+ public static String convertOpenWireToActiveMQFilterString(final String
selectorString) {
+ if (selectorString == null) {
+ return null;
+ }
+
+ String filterString =
SelectorTranslator.convertToActiveMQFilterString(selectorString);
+ filterString = SelectorTranslator.parse(filterString, "AMQUserID",
AMQ_MSG_MESSAGE_ID.toString());
Review Comment:
We should rather make this method public than bringing OpenWire concept into
commons.
If it was really needed (very difficult to go around) it's ok.. but this one
is easy to fix.
I have the change here and I'm amending as you before merging it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
