jbertram commented on PR #4172: URL: https://github.com/apache/activemq-artemis/pull/4172#issuecomment-1210999269
Couple of things: - All commits should be squashed into a single commit. You have multiple commits here that need to be squashed. - Tests are required to ensure the new code works as expected and to mitigate regressions in the future. You don't have any tests. - Commits need clear commit messages which indicate why the change is being made. - You need a Jira for changes of this size, and the Jira needs to be part of the commit message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
