gtully commented on code in PR #4185:
URL: https://github.com/apache/activemq-artemis/pull/4185#discussion_r953799585
##########
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml:
##########
@@ -144,10 +144,14 @@
${cluster-security.settings}${cluster.settings}${replicated.settings}${shared-st
<!-- the size of each file on paging. Notice we keep files in
memory while they are in use.
Lower this setting if you have too many queues in memory. -->
<page-size-bytes>10M</page-size-bytes>
- <!-- how many messages are kept in memory from paging. The system
will stop reading whenever this or max-read-page-bytes hits the max first. -->
- <max-read-page-messages>1000</max-read-page-messages>
+ <!-- how many messages are kept in memory from paging. The system
will stop reading whenever this or max-read-page-bytes hits the max first.
+ Change it to a positive value if you want to limit the number
of messages read.-->
+ <max-read-page-messages>-1</max-read-page-messages>
<!-- how many bytes equivalent of messages are kept in memory from
paging (based on memory estimate). The system will stop reading whenever this
or max-read-page-messages hits the max first. -->
<max-read-page-bytes>1M</max-read-page-bytes>
+ <!-- The system will not read any more messages if messages are
pending acks.
+ if you set this attribute to false, the broker will allow
more reading as soon as messages become on "delivering" state. -->
+ <page-read-flow-control>true</page-read-flow-control>
Review Comment:
I don't know any broker operator that will trust consumers, I would always
want the receive to block if the broker is constrained to the point that paging
in more messages would blow a limit that can lead to OOM. If I configure a
max-read, then I would want it to include delivered, and behave like the
flow-control bool is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
