[GitHub] [activemq-artemis] brusdev commented on a diff in pull request #4204: NO-JIRA Update Artemis download URL when creating a docker image

[GitBox]

brusdev commented on code in PR #4204:
URL: https://github.com/apache/activemq-artemis/pull/4204#discussion_r965186043


##########
artemis-docker/prepare-docker.sh:
##########
@@ -124,7 +124,7 @@ if [ -n "${FROM_RELEASE}" ]; then
 
   cleanup
   
-  ARTEMIS_BASE_URL="$(curl -s 
https://www.apache.org/dyn/closer.cgi\?preferred=true)activemq/activemq-artemis/${ARTEMIS_VERSION}/"
+  
ARTEMIS_BASE_URL="https://archive.apache.org/dist/activemq/activemq-artemis/${ARTEMIS_VERSION}/";

Review Comment:
   ```suggestion
     ARTEMIS_BASE_URL="$(curl -s 
https://www.apache.org/dyn/closer.cgi\?preferred=true)activemq/activemq-artemis/${ARTEMIS_VERSION}/"
     if ! curl --output /dev/null --silent --head --fail "${ARTEMIS_BASE_URL}"; 
then
       
ARTEMIS_BASE_URL="https://archive.apache.org/dist/activemq/activemq-artemis/${ARTEMIS_VERSION}/";
     fi
   ```
   The mirrored url should preferred if it exists.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org