gemmellr commented on code in PR #4208:
URL: https://github.com/apache/activemq-artemis/pull/4208#discussion_r969739886
##########
artemis-distribution/src/main/assembly/dep.xml:
##########
@@ -82,29 +82,6 @@
<directoryMode>0755</directoryMode>
<fileMode>0644</fileMode>
</dependencySet>
- <dependencySet>
- <includes>
- <include>org.apache.activemq:artemis-website</include>
- </includes>
- <excludes>
- <exclude>org.apache.activemq:artemis-website:jar:javadoc</exclude>
- </excludes>
- <outputDirectory>web</outputDirectory>
- <unpack>true</unpack>
- <useProjectArtifact>false</useProjectArtifact>
- <directoryMode>0755</directoryMode>
- <fileMode>0644</fileMode>
- </dependencySet>
- <dependencySet>
- <includes>
- <include>org.apache.activemq:artemis-website:jar:javadoc</include>
- </includes>
- <outputDirectory>web/api</outputDirectory>
- <unpack>true</unpack>
- <useProjectArtifact>false</useProjectArtifact>
- <directoryMode>0755</directoryMode>
- <fileMode>0644</fileMode>
- </dependencySet>
Review Comment:
These seem like they might mean the module is entirely unused here, in which
case it could be dropped from the assembly pom (note the 2 entries), and also
the related exclude further up this assembly file (line 51 atm)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
