gemmellr commented on PR #4225: URL: https://github.com/apache/activemq-artemis/pull/4225#issuecomment-1252244000
'Fix' the logger codes in what sense? Is it that they dont follow the 'number also conveys level' convention? I know @clebertsuconic hates that and doesnt intend doing it going forward (and various things clearly havent followed it historically) so I'm not sure this change actually makes sense at this point if thats the reason. Regardless it doesnt seem nice to swap codes of distinct messages to reusing codes that other messages were previously using, which this seems to do a couple times, and also leaves their original numbers open for reuse later for a couple more instances. If changing them they should probably use new non-clashing numbers, and try to prevent the other ones being reused; I think I saw mention of deprecating rather than removing methods to prevent that. It doesnt really seem like a NO-JIRA change whatever way it actually changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
