tabish121 commented on PR #4235: URL: https://github.com/apache/activemq-artemis/pull/4235#issuecomment-1261130569
> > Possible future enhancement would be to replace hard coding class names in logger definitions with Methodhandle lookups > > `Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());` > > This tends to help when cutting and pasting loggers and forgetting to change the class name. > > Yeah I didnt know about that trick, probably would be good to consider as I knew there were a few incorrect ones (forget it they are fixed in here, or were previously on main). But yes, I'd say better to do that separately later. Indeed the changes would be large given how many bad logging usages I see. Most of the gating that is currently done is either not needed or wouldn't be needed if loggers used the formatting style as they should. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
