gemmellr commented on code in PR #4273:
URL: https://github.com/apache/activemq-artemis/pull/4273#discussion_r1007001674
##########
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##########
@@ -244,7 +244,7 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("Attach Listener")) {
return true;
- } else if ((javaVendor.contains("IBM") || isSystemThread) &&
threadName.equals("process reaper")) {
+ } else if ((javaVendor.contains("IBM") || isSystemThread) &&
(threadName.equals("process reaper") || threadName.startsWith("process reaper
(pid"))) {
Review Comment:
It isnt always in the name, it comes and goes.
(EDIT: I misread the original question...yes I meant it, I only added the "
(pid" suffix without the remainder of the string since I wouldnt know the pid
it is actually working for at that point. I had decided not to just do
startsWith("process reaper") since it isnt as precise. But it is more concise
and unlikely to be an issue so I dont mind, changed.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
