jbertram commented on code in PR #4246: URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r1010470742
########## docs/user-manual/en/upgrading.md: ########## @@ -36,8 +36,8 @@ but the general process is as follows: If you run Artemis as a service on windows you have to do the following additional steps: -1. Navigate to the `bin` folder of the broker instance that's being upgraded -1. Open `artemis-service.xml`. It contains a property which is relevant for the upgrade: +3. Navigate to the `bin` folder of the broker instance that's being upgraded Review Comment: The numbers on these lines actually shouldn't change because this is a _new_ list of steps related to updating Windows (vs. the previous list of steps for updating *nix). ########## docs/user-manual/en/upgrading.md: ########## @@ -16,18 +16,18 @@ Because of this separation it's very easy to upgrade Artemis in most cases. > **Note:** > -> It's recommended to choose a folder different than the on where Apache +> It's recommended to choose a folder different from where Apache > Artemis was downloaded. This separation allows you run multiple broker > instances with the same Artemis "home" for example. It also simplifies > updating to newer versions of Artemis. - + ## General Upgrade Procedure Upgrading may require some specific steps noted in the [versions](versions.md), but the general process is as follows: 1. Navigate to the `etc` folder of the broker instance that's being upgraded -1. Open `artemis.profile` (`artemis.profile.cmd` on Windows). It contains a +2. Open `artemis.profile` (`artemis.profile.cmd` on Windows). It contains a Review Comment: The steps later are actually in reference to Windows so it should be a new list, not a continuation of this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
