jbertram commented on PR #4281: URL: https://github.com/apache/activemq-artemis/pull/4281#issuecomment-1305913524
I don't think this fix is valid as it's changing the semantics of the transaction rollback when a session fails. Previously _any_ pending transaction was rolled back whether or not it has a xid. Now you're only rolling back transactions with a xid which means in your test the transactions aren't being rolled back at all. It's perfectly valid for a transaction not to have a xid and such transactions should be rolled back when a session fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
