brusdev commented on code in PR #4302:
URL: https://github.com/apache/activemq-artemis/pull/4302#discussion_r1039151340
##########
artemis-protocols/artemis-openwire-protocol/src/test/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverterTest.java:
##########
@@ -248,6 +248,7 @@ public void testBadPropertyConversion() throws Exception {
coreMessage.putStringProperty(hdrBrokerInTime, "5678");
coreMessage.putStringProperty(hdrCommandId, "foo");
coreMessage.putStringProperty(hdrDroppable, "true");
+ coreMessage.putStringProperty("", "");
Review Comment:
Maybe CORE messages also should reject empty property names as OpenWire
messages:
```
java.lang.IllegalArgumentException: Property name cannot be empty or null
at
org.apache.activemq.command.ActiveMQMessage.setObjectProperty(ActiveMQMessage.java:497)
...
```
This would also avoid the error on converting to OpenWire CORE messages with
empty property names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
