gemmellr commented on code in PR #4302:
URL: https://github.com/apache/activemq-artemis/pull/4302#discussion_r1039795852
##########
artemis-protocols/artemis-openwire-protocol/src/test/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverterTest.java:
##########
@@ -248,6 +248,7 @@ public void testBadPropertyConversion() throws Exception {
coreMessage.putStringProperty(hdrBrokerInTime, "5678");
coreMessage.putStringProperty(hdrCommandId, "foo");
coreMessage.putStringProperty(hdrDroppable, "true");
+ coreMessage.putStringProperty("", "");
Review Comment:
Ah ok. I'd probably still add additional verification as without looking at
the git history and perhaps finding this discussion I'd still have no real idea
why that line was there in the test or what exactly to expect from it, given it
doesnt say or do any obvious related verification.
On the other bit, you could add verification on the setter and also a [URI]
option to disable it should someone truly need it. As the JIRA has no detail
its not clear how this is actually coming up currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
