jbertram commented on code in PR #4302:
URL: https://github.com/apache/activemq-artemis/pull/4302#discussion_r1042524382
##########
artemis-protocols/artemis-openwire-protocol/src/test/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverterTest.java:
##########
@@ -248,6 +248,7 @@ public void testBadPropertyConversion() throws Exception {
coreMessage.putStringProperty(hdrBrokerInTime, "5678");
coreMessage.putStringProperty(hdrCommandId, "foo");
coreMessage.putStringProperty(hdrDroppable, "true");
+ coreMessage.putStringProperty("", "");
Review Comment:
If a consumer using the core JMS client gets a message with an empty
property name it can retrieve the value using `getStringProperty("")`. The
empty name is also enumerated when using `javax.jms.Message#getPropertyNames`.
However, if you attempt to set a property with an empty name it will fail with
the expected `IllegalStateException`.
In short, supporting an empty property name in core seems a little weird,
but I don't see any spec violations here. Converting the core message
implementation to another implementation definitely could hit an
`IllegalStateException`, though, but that's not what this change is about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
