Yesenkov commented on PR #4308: URL: https://github.com/apache/activemq-artemis/pull/4308#issuecomment-1342597470
> I had to squash all your commits, and all you're doing is to only call true at the rollback(false) in case of individualAck > > your concern here is on the call to the plugin itself (based on your texts)? Well I am writing a test showing an error. If it is not necessary, then it is not necessary, we will not call Session.recover (), we will call Session.getCoreSession().rollback(), which works correctly. In the case of Session.Recover(), all unacknowledged messages should be returned to the queue, this is not only for the individual acknowledge mode, I just don't care about other modes. That is, in any case, rollback (false) from CoreSession should be called For unacknowledged messages, ActiveMQServerMessagePlugin.messageAcknowledged (Normal) should not be called, when acknowledged - must - this is important. The same situation in Session.rollback () - ActiveMQServerMessagePlugin.messageAcknowledged (Normal) should not be called. Current implementation callActiveMQServerMessagePlugin.messageAcknowledged (Normal) on Session.recover () & Session.rollback (). If calling from Session.recover () & Session.rollback () - Session.getCoreSession().rollback(false) - all works corectly, all messages on his right places, and all plugin calls maded correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
