gemmellr commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r1061352814
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java:
##########
@@ -60,6 +61,8 @@ public class ProtonServerReceiverContext extends
ProtonAbstractReceiver {
private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ private static final AtomicLong ID_GENERATOR = new AtomicLong();
Review Comment:
The brokers own differentiating ID wouldnt need to be the same as the
clients string id though. It would just be a broker-side conceptual id. Exactly
the same way broker assigns every message a long id for its own purposes, even
though messages often already include client-generated MessageID strings, and
individual protocols may have their own specific independent way of referencing
a particular message for acks etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
