maxfortun commented on PR #949: URL: https://github.com/apache/activemq/pull/949#issuecomment-1374049087
> @maxfortun sounds like the need is for additional extensions for registerJob (and for completeness, we should add unregisterJob). > > There is already a JobListener interface that has an operation to catch when scheduled messages are fired. I'm wondering if we could extend that by adding the 2 add'l methods. > > Then from there, confirm wiring in a custom JobListener (aka a mini-plugin just for Job events). > > Thoughts? I also initially thought that the JobListener is the correct place for this feature, but since I am not familiar enough with the broker internals and maintainers philosophy I did not want to make any changes that are not backward compatible. If we change the JobListener interface then the upgrades for people who have any custom scheduler modules for the broker will no longer be a drop in easy-peasy process and would require quite a bit of work. Which may be ok, if that's how activemq is developed. Also, currently there is only 1 listener, and it is the `SchedulerBroker`, which is added and removed when broker starts and stops. I presume this is for the failover support. Using job listeners may make this feature more of a rearchitecture than a feature. I am not certain that this deserves so much effort. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
