NikitaShupletsov commented on PR #848: URL: https://github.com/apache/activemq/pull/848#issuecomment-1377611153
>I haven't gone through much of this yet but the number 1 thing is anything here needs to be isolated and as Matt pointed out I have some concerns with internal changes. This needs to not impact anything in the broker if it's not running so any changes that would impact performance or could introduce other issues/bugs would be a problem. Essentially if it's disabled (which it will be by default) then the broker shouldn't behave any differently than today. i totally agree. We changed the internal classes just to add a couple methods(and modified one that hasn't been used since pure master-slave was deleted). Hence nothing should be impacted by the changes when the plugin is turned off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
