NikitaShupletsov commented on code in PR #953:
URL: https://github.com/apache/activemq/pull/953#discussion_r1068483608


##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -2387,8 +2495,8 @@ private QueueMessageReference 
getMatchingMessage(MessageDispatchNotification mes
                     messages.reset();
                     while (messages.hasNext()) {
                         MessageReference node = messages.next();
-                        messages.remove();

Review Comment:
   The idea of this change is to delete only the message that we are looking 
for. Because deleting all messages up to the one we need prevents reading them 
in future. Basically if we delete them here, we will not be able to get them 
anymore. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to