gemmellr commented on code in PR #4338:
URL: https://github.com/apache/activemq-artemis/pull/4338#discussion_r1082674555
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java:
##########
@@ -128,11 +133,17 @@ public void storeLineUp() {
@Override
public void replicationLineUp() {
REPLICATION_LINEUP_UPDATER.incrementAndGet(this);
+ if (logger.isTraceEnabled()) {
Review Comment:
I decide based on how hot the path is. If its 'relatively occasional' I'll
just let it box if it leaves things a lot nicer to read. If its very hot, I'll
gate it. I have no idea in this case :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]