gemmellr commented on code in PR #4338:
URL: https://github.com/apache/activemq-artemis/pull/4338#discussion_r1084080398
##########
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##########
@@ -2447,6 +2447,14 @@
</xsd:documentation>
</xsd:annotation>
</xsd:attribute>
+ <xsd:attribute name="sync" type="xsd:boolean" use="optional"
default="true">
+ <xsd:annotation>
+ <xsd:documentation>
+ If this is true, producers will be waiting a response from the
mirror before the sync is finished.
+ This is false by default.
Review Comment:
Is there a test for these type of defaults that could be updated to check
this value? I notice no test needed to change when you updated it, which
probably explains how it came to be incorrect without notice to begin with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
