clebertsuconic commented on code in PR #4363:
URL: https://github.com/apache/activemq-artemis/pull/4363#discussion_r1106125909
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java:
##########
@@ -86,11 +86,21 @@ public boolean add(T t) {
return result;
}
+ @Override
+ public void removed(T t) {
+ iterator.removed(t);
+ }
+
@Override
public boolean remove(T t) {
+ iterator.removed(t);
boolean result = consumers.remove(t);
if (result) {
iterator.update(consumers.resettableIterator());
+ if (consumers.isEmpty()) {
+ // TODO: can I always reset?
+ reset();
+ }
Review Comment:
I will keep it..
and remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
