clebertsuconic commented on code in PR #4375:
URL: https://github.com/apache/activemq-artemis/pull/4375#discussion_r1119640420
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java:
##########
@@ -418,6 +418,17 @@ public void cancel(Object brokerConsumer, Message message,
boolean updateCounts)
}
}
+ /** to be used when credits were drained between handle and actual delivery
*/
+ public void returnToQueue(Object brokerConsumer, MessageReference
reference) {
Review Comment:
@michaelandrepearce those issues we had were mostly related to closing
consumers with a lot of pre-fetch in the queue, which is an anti-pattern. One
user reported issues here, and even though we will make sure he changes his
usage,I still wanted to fix these.
Although the Iterator and Journal were issues independent of prefetch or
AMQP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
