gemmellr commented on PR #4385: URL: https://github.com/apache/activemq-artemis/pull/4385#issuecomment-1449911427
I havent looked at the code yet, but have a more general wonder about this change. Not all that long ago we effectively made an opposite kind of change in the failover bits of qpid-jms to resolve an issue where its use of resolved IPs for hostnames actually broke things. We made it stop resolving failover hosts to their IPs for comparison and just use the hostname string values as given, because resolving them like it previously did meant it would often be de-duping away entirely distinct hostname values that all just happened to resolve to the same IP, which is a lot more common these days than when the original code was written, due to use of TLS SNI in general and specifically in cloud environments (e.g connections hitting some form of gateway that uses SNI to determine which 'host' is actually being connected to). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
