clebertsuconic commented on code in PR #4388:
URL: https://github.com/apache/activemq-artemis/pull/4388#discussion_r1123945169
##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/upgradeTest/CompareUpgradeTest.java:
##########
@@ -149,7 +149,12 @@ private void compareDirectories(String expectedFolder,
String upgradeFolder, Str
String expectedString =
expectedIterator.next().replace("Expected", "").trim();
String upgradeString = upgradeIterator.next().trim();
- Assert.assertEquals("error on line " + line + " at " +
upgradeFile, expectedString, upgradeString);
+
+ if (f.getName().endsWith("xml") &&
expectedString.trim().startsWith("<!--") &&
upgradeString.trim().startsWith("<!--")) {
+ logger.debug("Both {} and {} are comments, which I don't
really mind what's going on inside the comment", expectedString, upgradeString);
Review Comment:
@gemmellr it's not that simple to generate the jolokia-access.xml
we would have to parse the host-name and if we are relaxing jolokia or not.
At this point we should just ignore the comment on this file. Going beyond
that would take a long time.
I will just update the test to ignore comments on this file only.
We could deal with that in the future if we have to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
