gemmellr commented on code in PR #4388:
URL: https://github.com/apache/activemq-artemis/pull/4388#discussion_r1124623112
##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/upgradeTest/CompareUpgradeTest.java:
##########
@@ -149,7 +149,12 @@ private void compareDirectories(String expectedFolder,
String upgradeFolder, Str
String expectedString =
expectedIterator.next().replace("Expected", "").trim();
String upgradeString = upgradeIterator.next().trim();
- Assert.assertEquals("error on line " + line + " at " +
upgradeFile, expectedString, upgradeString);
+
+ if (f.getName().endsWith("xml") &&
expectedString.trim().startsWith("<!--") &&
upgradeString.trim().startsWith("<!--")) {
+ logger.debug("Both {} and {} are comments, which I don't
really mind what's going on inside the comment", expectedString, upgradeString);
Review Comment:
I wasnt suggesting generating anything. I was saying, we should change the
initial pre-upgrade file, which is also the post-upgrade reference in this
case, to just match what the test is already causing to be generated by the new
broker...since we dont actually upgrade that file currently, just copy it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
