cshannon commented on code in PR #988:
URL: https://github.com/apache/activemq/pull/988#discussion_r1135294050
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+ @Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setWaitForSlave(boolean waitForSlave) {
this.waitForSlave = waitForSlave;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+ @Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+ @Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setWaitForSlave(boolean waitForSlave) {
this.waitForSlave = waitForSlave;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public long getWaitForSlaveTimeout() {
return this.waitForSlaveTimeout;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public void setWaitForSlaveTimeout(long waitForSlaveTimeout) {
this.waitForSlaveTimeout = waitForSlaveTimeout;
}
/**
- * Get the passiveSlave
- * @return the passiveSlave
+ * Deprecated: this method will be renamed to not use slave wording
*/
+ @Deprecated(forRemoval = true)
public boolean isPassiveSlave() {
return this.passiveSlave;
}
/**
- * Set the passiveSlave
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+ @Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setWaitForSlave(boolean waitForSlave) {
this.waitForSlave = waitForSlave;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public long getWaitForSlaveTimeout() {
return this.waitForSlaveTimeout;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public void setWaitForSlaveTimeout(long waitForSlaveTimeout) {
this.waitForSlaveTimeout = waitForSlaveTimeout;
}
/**
- * Get the passiveSlave
- * @return the passiveSlave
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+ @Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setWaitForSlave(boolean waitForSlave) {
this.waitForSlave = waitForSlave;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public long getWaitForSlaveTimeout() {
return this.waitForSlaveTimeout;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
Review Comment:
```suggestion
* @deprecated it will be removed as it should not be used directly.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
