Jefwillems commented on PR #86: URL: https://github.com/apache/activemq-nms-amqp/pull/86#issuecomment-1472165175
> @Jefwillems thanks, just need to squash the commits and adjust the commit message to be correctly formed and include the JIRA id. > > @Havret any objections here? it looks good to me. On review i noted that we're also missing REJECTED ack type, see here in java variant: https://github.com/apache/qpid-jms/blob/main/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java#L317 Any reason it was left out? @Havret i tried squashing but something went wrong, i had to reimplement the tests and the reject outcome. The new commits have the Jira issue in them, but i'm afraid if i try squashing again i'll mess things up. In theory, you should be able to squash commits when merging, if you're merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
