gemmellr commented on code in PR #4401:
URL: https://github.com/apache/activemq-artemis/pull/4401#discussion_r1139093199
##########
artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java:
##########
@@ -176,6 +178,12 @@
*/
public abstract class ActiveMQTestBase extends Assert {
+ public MBeanServer getMBeanServer() {
+ MBeanServer mBeanServer = MBeanServerFactory.createMBeanServer();
+ runAfter(() -> MBeanServerFactory.releaseMBeanServer(mBeanServer));
+ return mBeanServer;
+ }
Review Comment:
Renaming this something like createMBeanServer() would seem appropriate now,
given its no longer doing the simple get it started out as in the previously
reviewed version, and this method is only called in place of prior
MBeanServerFactory.createMBeanServer() uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
