gemmellr commented on code in PR #4404:
URL: https://github.com/apache/activemq-artemis/pull/4404#discussion_r1139104096
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
##########
@@ -1391,7 +1395,8 @@ public Pair<RoutingContext, Message> redistribute(final
Message message,
// We have to copy the message and store it separately, otherwise we
may lose remote bindings in case of restart before the message
// arrived the target node
// as described on https://issues.jboss.org/browse/JBPAPP-6130
- Message copyRedistribute = message.copy(storageManager.generateID());
+ final Message copyRedistribute =
message.copy(storageManager.generateID());
+ logger.info("Message {} being copied as {}", message.getMessageID(),
copyRedistribute.getMessageID());
Review Comment:
I find it a good habit to mark such 'temp dev/debugging logging' changes
with TODOs when making the change, its then much harder to forget to miss e.g
setting them to the correct level (or removing them) later when reviewing
things before pushing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
