tabish121 commented on code in PR #4421:
URL: https://github.com/apache/activemq-artemis/pull/4421#discussion_r1153577596
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java:
##########
@@ -111,7 +112,7 @@ public interface ServerSession extends SecurityAuth {
void addCloseable(Closeable closeable);
- boolean checkAutoCreate(SimpleString address, RoutingType routingType)
throws Exception;
+ AutoCreateResult checkAutoCreate(QueueConfiguration queueConfiguration)
throws Exception;
Review Comment:
Overall this change seems a positive one in terms making this API more
flexible I wonder if adding some simple builder type static APIs in
QueueConfiguration might be a good idea as I see a lot of boilerplate code in
many of the if statements no to create and configure the QueueConfiguration
object (e.g. new
QueueConfiguration(address).setRoutingType(context.getRoutingType())) which
might read better with a simpler QueueConfiguration.of(address, routingType)
call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
