tabish121 commented on PR #4426: URL: https://github.com/apache/activemq-artemis/pull/4426#issuecomment-1499166877
> > .. as the test then wasnt using an empty map message at all it just didnt seem like it was exercising the reported issue / main change at all. > > Yeah, so...its been pointed out to me that it wasnt adding anything to the map...just the properties...which somehow I was completely oblivious to. Oopsie :) It might be good to check that an totally empty message (no properties or body) was handled as well, or check that it was tested someplace else, possible a check for each type although I think the Openwire marshaler handles the "content" portion the same in each message type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
