gemmellr commented on code in PR #4425:
URL: https://github.com/apache/activemq-artemis/pull/4425#discussion_r1159942575
##########
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml:
##########
@@ -134,31 +134,36 @@
${cluster-security.settings}${cluster.settings}${replicated.settings}${shared-st
<expiry-address>ExpiryQueue</expiry-address>
<redelivery-delay>0</redelivery-delay>
- <!-- if max-size-bytes and max-size-messages were both enabled,
the system will enter into paging
- based on the first attribute to hits the maximum value -->
- <!-- limit for the address in bytes, -1 means unlimited -->
- <max-size-bytes>-1</max-size-bytes>
+
<message-counter-history-day-limit>10</message-counter-history-day-limit>
+ <address-full-policy>${full-policy}</address-full-policy>
+ <auto-create-queues>${auto-create}</auto-create-queues>
+ <auto-create-addresses>${auto-create}</auto-create-addresses>
+ <auto-delete-queues>${auto-delete}</auto-delete-queues>
+ <auto-delete-addresses>${auto-delete}</auto-delete-addresses>
+
+ <!--
************************************************************************************************************
-->
+ <!-- The size of each file
-->
+ <page-size-bytes>10M</page-size-bytes>
- <!-- limit for the address in messages, -1 means unlimited -->
+ <!--
************************************************************************************************************
-->
+ <!-- when we start paging (Or whatever is the full policy)
-->
+
+ <!-- both are disabled by default, what means we will use
global-max unless they are defined -->
Review Comment:
```suggestion
<!-- When we start applying the address-full-policy, e.g paging
-->
<!-- Both are disabled by default, which means we will use the
global-max-size/global-max-messages -->
```
##########
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml:
##########
@@ -134,31 +134,36 @@
${cluster-security.settings}${cluster.settings}${replicated.settings}${shared-st
<expiry-address>ExpiryQueue</expiry-address>
<redelivery-delay>0</redelivery-delay>
- <!-- if max-size-bytes and max-size-messages were both enabled,
the system will enter into paging
- based on the first attribute to hits the maximum value -->
- <!-- limit for the address in bytes, -1 means unlimited -->
- <max-size-bytes>-1</max-size-bytes>
+
<message-counter-history-day-limit>10</message-counter-history-day-limit>
+ <address-full-policy>${full-policy}</address-full-policy>
+ <auto-create-queues>${auto-create}</auto-create-queues>
+ <auto-create-addresses>${auto-create}</auto-create-addresses>
+ <auto-delete-queues>${auto-delete}</auto-delete-queues>
+ <auto-delete-addresses>${auto-delete}</auto-delete-addresses>
+
+ <!--
************************************************************************************************************
-->
+ <!-- The size of each file
-->
Review Comment:
I dont think all the seperators are needed, just the comment is fine. (Its
also rather inconsistent with the rest of the file.)
```suggestion
<!-- The size of each page file -->
```
##########
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml:
##########
@@ -134,31 +134,36 @@
${cluster-security.settings}${cluster.settings}${replicated.settings}${shared-st
<expiry-address>ExpiryQueue</expiry-address>
<redelivery-delay>0</redelivery-delay>
- <!-- if max-size-bytes and max-size-messages were both enabled,
the system will enter into paging
- based on the first attribute to hits the maximum value -->
- <!-- limit for the address in bytes, -1 means unlimited -->
- <max-size-bytes>-1</max-size-bytes>
+
<message-counter-history-day-limit>10</message-counter-history-day-limit>
+ <address-full-policy>${full-policy}</address-full-policy>
+ <auto-create-queues>${auto-create}</auto-create-queues>
+ <auto-create-addresses>${auto-create}</auto-create-addresses>
+ <auto-delete-queues>${auto-delete}</auto-delete-queues>
+ <auto-delete-addresses>${auto-delete}</auto-delete-addresses>
+
+ <!--
************************************************************************************************************
-->
+ <!-- The size of each file
-->
+ <page-size-bytes>10M</page-size-bytes>
- <!-- limit for the address in messages, -1 means unlimited -->
+ <!--
************************************************************************************************************
-->
+ <!-- when we start paging (Or whatever is the full policy)
-->
+
+ <!-- both are disabled by default, what means we will use
global-max unless they are defined -->
+ <max-size-bytes>-1</max-size-bytes>
<max-size-messages>-1</max-size-messages>
- <!-- the size of each file on paging. Notice we keep files in
memory while they are in use.
- Lower this setting if you have too many queues in memory. -->
- <page-size-bytes>10M</page-size-bytes>
+ <!--
************************************************************************************************************
-->
+ <!-- when we read from paging into queues (memory)
-->
Review Comment:
```suggestion
<!-- When we read from paging into queues (memory) -->
```
##########
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml:
##########
@@ -134,31 +134,36 @@
${cluster-security.settings}${cluster.settings}${replicated.settings}${shared-st
<expiry-address>ExpiryQueue</expiry-address>
<redelivery-delay>0</redelivery-delay>
- <!-- if max-size-bytes and max-size-messages were both enabled,
the system will enter into paging
- based on the first attribute to hits the maximum value -->
- <!-- limit for the address in bytes, -1 means unlimited -->
- <max-size-bytes>-1</max-size-bytes>
+
<message-counter-history-day-limit>10</message-counter-history-day-limit>
+ <address-full-policy>${full-policy}</address-full-policy>
+ <auto-create-queues>${auto-create}</auto-create-queues>
+ <auto-create-addresses>${auto-create}</auto-create-addresses>
+ <auto-delete-queues>${auto-delete}</auto-delete-queues>
+ <auto-delete-addresses>${auto-delete}</auto-delete-addresses>
+
+ <!--
************************************************************************************************************
-->
+ <!-- The size of each file
-->
+ <page-size-bytes>10M</page-size-bytes>
- <!-- limit for the address in messages, -1 means unlimited -->
+ <!--
************************************************************************************************************
-->
+ <!-- when we start paging (Or whatever is the full policy)
-->
+
+ <!-- both are disabled by default, what means we will use
global-max unless they are defined -->
+ <max-size-bytes>-1</max-size-bytes>
<max-size-messages>-1</max-size-messages>
- <!-- the size of each file on paging. Notice we keep files in
memory while they are in use.
- Lower this setting if you have too many queues in memory. -->
- <page-size-bytes>10M</page-size-bytes>
+ <!--
************************************************************************************************************
-->
+ <!-- when we read from paging into queues (memory)
-->
- <!-- limit how many messages are read from paging into the Queue.
-->
<max-read-page-messages>-1</max-read-page-messages>
-
- <!-- limit how much memory is read from paging into the Queue. -->
<max-read-page-bytes>20M</max-read-page-bytes>
-
<message-counter-history-day-limit>10</message-counter-history-day-limit>
- <address-full-policy>${full-policy}</address-full-policy>
- <auto-create-queues>${auto-create}</auto-create-queues>
- <auto-create-addresses>${auto-create}</auto-create-addresses>
- <auto-delete-queues>${auto-delete}</auto-delete-queues>
- <auto-delete-addresses>${auto-delete}</auto-delete-addresses>
- </address-setting>
+ <!--
************************************************************************************************************
-->
+ <!-- when to start throwing errors after paging
-->
+
Review Comment:
```suggestion
<!-- Limit on paging capacity before starting to throw errors -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
