gemmellr commented on code in PR #4421:
URL: https://github.com/apache/activemq-artemis/pull/4421#discussion_r1168574598
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/QueueAutoCreationTest.java:
##########
@@ -124,7 +124,7 @@ public void testAutoCreateOnTopic() throws Exception {
Connection connection = factory.createConnection();
SimpleString addressName =
UUIDGenerator.getInstance().generateSimpleStringUUID();
logger.debug("Address is {}", addressName);
- clientSession.createAddress(addressName, RoutingType.ANYCAST, false);
+ clientSession.createAddress(addressName, RoutingType.MULTICAST, false);
Review Comment:
That I dont quite understand. The same change was and still is being made in
the basically-same test in
[AutoCreateJmsDestinationTest.java](https://github.com/apache/activemq-artemis/pull/4421/files#diff-6afa2ca2a98c6d517b31d95108be8a9a803968254c6f27bb739bc0bed395c2ae),
so now we have 2 tests creating addresses with different routing types, one
multicast and one anycast, and yet both sending to them as a Topic...isnt that
exactly 'sending msgs to address w/mismatching routing types' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
