gemmellr commented on code in PR #4448:
URL: https://github.com/apache/activemq-artemis/pull/4448#discussion_r1175301832
##########
artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java:
##########
@@ -1328,6 +1330,17 @@ protected static final void waitForComponent(final
ActiveMQComponent component,
}
}
+ protected static final void waitForBridges(final ActiveMQServer server, int
connectedBridges) throws Exception {
+ waitForBridges(server.getClusterManager().getDefaultConnection(null),
connectedBridges);
+ }
+
+ protected static final void waitForBridges(ClusterConnection
clusterConnection, int connectedBridges) throws Exception {
+ Bridge[] bridges = clusterConnection.getBridges();
Review Comment:
This doesnt look used. Is it needed? Was a quick-exit check intended but
missed?
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java:
##########
@@ -630,6 +630,11 @@ public long getCallTimeout() {
return callTimeout;
}
+ @Override
+ public Bridge[] getBridges() {
+ return
records.values().stream().map(MessageFlowRecord::getBridge).toArray(Bridge[]::new);
Review Comment:
The 'records' field has 'recordsGuard' to protect its use in other cases. Is
that needed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
