gtully commented on code in PR #4447:
URL: https://github.com/apache/activemq-artemis/pull/4447#discussion_r1176456963
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ServerLocator.java:
##########
@@ -653,6 +653,21 @@ ClientSessionFactory
createSessionFactory(TransportConfiguration transportConfig
*/
int getInitialConnectAttempts();
+ /**
+ * Sets the maximum number of attempts to establish a connection after a
failed reconnection.
Review Comment:
should that be "failed connection" rather than "failed reconnection"
##########
docs/user-manual/en/client-reconnection.md:
##########
@@ -89,9 +89,20 @@ Client reconnection is configured using the following
parameters:
ridiculously large values. By setting this parameter you can set an upper
limit
on that value. The default value is `2000` milliseconds.
+- `ha`. This optional parameter determines weather the client will try to
+ reconnect to the backup node when the live node is not reachable.
+ The default value is `false`.
+ For more information on HA, please see [High Availability and
Failover](ha.md).
+
- `reconnectAttempts`. This optional parameter determines the total number of
- reconnect attempts to make before giving up and shutting down. A value of
- `-1` signifies an unlimited number of attempts. The default value is `0`.
+ reconnect attempts to make to the current live/backup pair before giving up.
Review Comment:
I am confused :-)
I thought failover was between live and backup
reconnect should first try to failover, then fall back to any connection to
eventually reconnect. these seems the opposite.
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ServerLocator.java:
##########
@@ -653,6 +653,21 @@ ClientSessionFactory
createSessionFactory(TransportConfiguration transportConfig
*/
int getInitialConnectAttempts();
+ /**
+ * Sets the maximum number of attempts to establish a connection after a
failed reconnection.
Review Comment:
maximum number of attempts to reconnect after a failure. But I may have this
wrong!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
